feat(pipeline): implement normalize progress tracking for JSON normalizer #1639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dlt-hub-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
For the case when we're first extracting data and then normalizing, it works fine
The code is chained, so it requires to through some args through several functions/classes. Tried to reduce it as much as possible. Thinking about how to test it... Seems to me something cunning is needed. However, the code is working for the case when we're extracting and then normalizing data. |
IlyaFaer
changed the title
IlyaFaer
changed the title
IlyaFaer
force-pushed
the
feat/1567-dict-normalize-progress
branch
from
491efaf to
5795b14
Compare
|
collected metrics will not go through process boundary, we'll need different approach here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #1567
Implements item 1 for
JsonLItemsNormalizer